Cleaning up: Things to be removed

[Jay]

After the File structure has been organised in accordance to the roadmap (which doesn't exist yet, but Fireburns working on it) we need to start the cleaning. Obviously, this will take a while. There are a lot of things that are unused in LVP that should be removed. Other things that are simply too messy or too inefficient should be rewritten. 

Please add your thoughts and anything you disagree with!

Key:

* To be rewritten
* To be removed
* To be improved

Items marked with a  star (*) should just be cleaned up (added to the relevant file instead of just plonked in one).

* Deathmatch minigame handler
* DM Champ system
* AddVehicle functions
* Random vehicle spawner
* Spawn positions
* Spawn weapon system
* Phone system (/call)
* Kill time
* Virtual World system
* Player colour system*
* SavePlayerGuns functions*
* Ramping*
* /borrow and tax system*
* Login and class selection process*
* Race Builder*
* Haystack*
* Player Hide functions (/my hide)*
* Imports*
* Barrels*

* All unused functions

* Automatic weather changes
* Hidden packages
* (Unfinished) 2.90 Phone handler
* (Unfinished) 2.90 Gang base handler
* Interior weapon handler

* Auto Bahn Imports
* CarCrusher
* Rivershell
* Lyse
* Lottery
* Capture the briefcase


This isn't everything. The LVP source is over 65,000 lines of code. 64,999 lines of that code is messy. So reply with things you wish to add so we can compile a list when it comes down to doing it!

[Fireburn]

A good startlist, thanks for the work Jay, there's a few things I'd like to note about it. First of all, as we agreed some handlers are going to be completly rewritten, which is why we need to look for things we shouldn't do right now. An example is SavePlayerGuns, which is, if I recall it correctly, also used by minigames, and we are going to rewrite the minigame handler.
So let's also take a look at things that don't need changing right now. I'll take a look in the source this afternoon to see if I can see anything that we could improve.

[Matthias]

Why should the interior handler system be removed?

[Jay]

The interior weapon handler was deprecated for 2.91 a while back and isn't being used.

Handlers/Weapons.pwn

[Fireburn]

What Jay says. We fixed the setplayerteam problems so we do not.need the interior handler anymore.

[Wesley]

Just to be clear on something, if you add a new handler or rewrite one, please use the classes the precompiler provides. Don't use the fake C.. classes anymore

[thiaZ]

A sentence with things that should be improved would be nice for the 'Rewritten' things.

[Fireburn]

* Deathmatch minigame handler We should do this after we have a new minigame handler
* AddVehicle functions I'd rather have a rewrite of our entire vehicle handler
* Random vehicle spawner I'd rather have a rewrite of our entire vehicle handler as a new thing
* Race Builder* I'd wait for this untill we have our new minigame/racehandler and then add a shiny builder in
* Haystack* to be done after the new minigame handler?

* Rivershell
* Lyse
* Lottery
* Capture the briefcase
All of the above should be done when we have a new minigame handler.

As you can see, I think a few things should be done later on in the process, after we've done a new vehicle/minigame/race handler, meaning those handlers are quite important, as a lot of things in the later process will depend on these handlers, so these handlers should be completly rewritten (milestone 3?).

[Matthias]

Well, I'm kinda afraid of using classes right now, since I worked 3 days straight at my WWTW class handler but never got it to compile. There's quite a few bugs I found with the PreCompiler.

[Jay]

How about creating a new section on the trac so that we can report precompiler issues?